Bugfix/setting service ensure to stopped causes failure #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoblitt
approved these changes
Sep 20, 2019
There was a problem hiding this comment.
If folks in the wild are sending notifications for Exec['firewall::reload'], this is probably the only real option. I am leaning towards the opinion that having a public class to receive notifications is a preferable pattern, as in this sort of scenario the exec resource could be removed from the catalog completely.
/CC @alexjfisher
|
@jschoewe Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for issue 164. If the firewalld service is running and this module is called with service_ensure => 'stopped' then the puppet run fails because firewall-cmd commands need the firewalld service to be running in order to work.
#164